Request object not given to confirm_redirect_uri#504
Merged
skion merged 2 commits intooauthlib:masterfrom Apr 13, 2018
jimmy-lt:fix/504-confirm-redirect-uri-request
Merged
Request object not given to confirm_redirect_uri#504skion merged 2 commits intooauthlib:masterfrom jimmy-lt:fix/504-confirm-redirect-uri-request
skion merged 2 commits intooauthlib:masterfrom
jimmy-lt:fix/504-confirm-redirect-uri-request
Conversation
Member
|
I see no reason not to do this: It aligns the validator signature with most of the others without a breaking change. 👍 |
JonathanHuot
approved these changes
Mar 29, 2018
Member
JonathanHuot
left a comment
There was a problem hiding this comment.
Thanks for the report.
It seems the be the only method which doesn't have request. Odd!
LGTM
skion
approved these changes
Mar 29, 2018
Closed
Merged
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the request object is never given to the
confirm_redirect_uri.This is an issue since I enclose the database session within the request object. That means that I cannot proceed with the query to fulfill the request.