Skip to content

Use secrets module in Python 3.6 and later#533

Merged
skion merged 2 commits intooauthlib:masterfrom
oohlaf:secret
Apr 13, 2018
Merged

Use secrets module in Python 3.6 and later#533
skion merged 2 commits intooauthlib:masterfrom
oohlaf:secret

Conversation

@oohlaf
Copy link
Copy Markdown
Contributor

@oohlaf oohlaf commented Mar 26, 2018

The secrets module should be used for generating cryptographically
strong random numbers suitable for managing data such as passwords,
account authentication, security tokens, and related secrets.

In particularly, secrets should be used in preference to the default
pseudo-random number generator in the random module, which is
designed for modelling and simulation, not security or cryptography.

The secrets module should be used for generating cryptographically
strong random numbers suitable for managing data such as passwords,
account authentication, security tokens, and related secrets.

In particularly, secrets should be used in preference to the default
pseudo-random number generator in the random module, which is
designed for modelling and simulation, not security or cryptography.
Copy link
Copy Markdown
Member

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skion skion added this to the 2.1.0 milestone Mar 29, 2018
@skion skion modified the milestones: 2.1.0, 2.0.8 Mar 29, 2018
@skion skion merged commit d21fd53 into oauthlib:master Apr 13, 2018
skion pushed a commit to skion/oauthlib that referenced this pull request Apr 23, 2018
The secrets module should be used for generating cryptographically
strong random numbers suitable for managing data such as passwords,
account authentication, security tokens, and related secrets.

In particularly, secrets should be used in preference to the default
pseudo-random number generator in the random module, which is
designed for modelling and simulation, not security or cryptography.

(cherry picked from commit d21fd53)
@skion skion mentioned this pull request May 8, 2018
@skion skion mentioned this pull request May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants