fix: handle array response from routine create/update API#3
Open
fix: handle array response from routine create/update API#3
Conversation
The Hevy API returns routine folder IDs as JSON numbers, but the Go structs declared them as strings, causing json.Unmarshal to fail with "cannot unmarshal number into Go struct field RoutineFolder.id of type string". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Hevy API returns the routine field as an array in POST/PUT responses, but the client expected a single object, causing unmarshal errors when creating or updating routines. Fixes obay#2
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis change converts folder IDs from strings to integers across CLI and API layers, updates routine create/update response handling to expect an array of routines, and removes Homebrew Cask and Scoop release targets while updating the GitHub release owner in the release config. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
cmd/folder/get.go (2)
22-24: Update command examples to reflect integer folder IDs.The examples show UUID-style IDs (
abc123-def456) but folder IDs are now integers. Consider updating for consistency.Suggested update
Examples: - hevycli folder get abc123-def456 # Get folder by ID - hevycli folder get abc123 -o json # Output as JSON`, + hevycli folder get 123 # Get folder by ID + hevycli folder get 123 -o json # Output as JSON`,🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/folder/get.go` around lines 22 - 24, Update the help/examples for the "hevycli folder get" command to use integer IDs instead of UUID-style strings: replace examples like "abc123-def456" with an integer example (e.g., "123") and update the JSON example accordingly ("hevycli folder get 123 -o json"); locate and edit the examples block associated with the folder get command (the help/example string for the "hevycli folder get" command) so the displayed usage matches the current integer folder ID format.
74-75: Consider handling the parse error for defensive coding.While the error is unlikely since you control the format on line 63, silently ignoring parse errors could lead to unexpected behavior (folderID defaults to 0) if the format changes in the future.
Proposed fix
- folderID, _ = strconv.Atoi(selected.ID) + var parseErr error + folderID, parseErr = strconv.Atoi(selected.ID) + if parseErr != nil { + return fmt.Errorf("invalid folder ID selected: %s", selected.ID) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/folder/get.go` around lines 74 - 75, The code silently ignores the strconv.Atoi error when parsing selected.ID into folderID which can leave folderID as 0; update the parse to capture the error (e.g., val, err := strconv.Atoi(selected.ID)) and handle it—either return the error up the call stack, log a clear message and exit, or provide a safe fallback—so that malformed selected.ID is detected and handled rather than silently defaulting folderID; reference the strconv.Atoi call, the selected.ID value, and the folderID variable when implementing the change.cmd/folder/delete.go (1)
90-91: Consider handling the parse error for defensive coding.Same concern as in
cmd/folder/get.go- silently ignoring the parse error could cause unexpected behavior iffolderIDdefaults to 0.Proposed fix
- folderID, _ = strconv.Atoi(selected.ID) + var parseErr error + folderID, parseErr = strconv.Atoi(selected.ID) + if parseErr != nil { + return fmt.Errorf("invalid folder ID selected: %s", selected.ID) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/folder/delete.go` around lines 90 - 91, The code is ignoring the error returned by strconv.Atoi when converting selected.ID to folderID; update the strconv.Atoi call to capture the error (e.g., folderID, err := strconv.Atoi(selected.ID)), check err, and handle it defensively by returning or exiting with a clear error message (or logging) so folderID won't silently be 0; apply the same pattern used in cmd/folder/get.go for consistent error handling around folderID and selected.ID.cmd/folder/update.go (1)
84-84: Consider handling the conversion error defensively.The error from
strconv.Atoiis ignored. While theselected.IDoriginates from a formatted integer (line 73), handling the error would prevent silent failures if the data flow changes in the future.🛡️ Proposed fix for defensive error handling
- folderID, _ = strconv.Atoi(selected.ID) + folderID, err = strconv.Atoi(selected.ID) + if err != nil { + return fmt.Errorf("invalid folder ID from selection: %s", selected.ID) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/folder/update.go` at line 84, The conversion of selected.ID with strconv.Atoi currently ignores the error; change the code to capture the returned (id, err) from strconv.Atoi(selected.ID) and handle err defensively (e.g., return the error from the surrounding function or log and exit) before assigning folderID so the program fails loudly if selected.ID is not a valid integer; update the folderID assignment site to use the parsed id variable and ensure any error path provides a clear message referencing selected.ID.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.goreleaser.yaml:
- Line 67: The goreleaser "owner: asabirov" entry mismatches the module path in
go.mod ("module github.com/obay/hevycli"); update the Goreleaser owner to the
correct GitHub org/user (change owner: asabirov to owner: obay) or, if the
repository has intentionally moved, update the module path in go.mod to match
the new owner; ensure the "owner" field and the go.mod module path are
consistent so releases are published to the correct repo.
---
Nitpick comments:
In `@cmd/folder/delete.go`:
- Around line 90-91: The code is ignoring the error returned by strconv.Atoi
when converting selected.ID to folderID; update the strconv.Atoi call to capture
the error (e.g., folderID, err := strconv.Atoi(selected.ID)), check err, and
handle it defensively by returning or exiting with a clear error message (or
logging) so folderID won't silently be 0; apply the same pattern used in
cmd/folder/get.go for consistent error handling around folderID and selected.ID.
In `@cmd/folder/get.go`:
- Around line 22-24: Update the help/examples for the "hevycli folder get"
command to use integer IDs instead of UUID-style strings: replace examples like
"abc123-def456" with an integer example (e.g., "123") and update the JSON
example accordingly ("hevycli folder get 123 -o json"); locate and edit the
examples block associated with the folder get command (the help/example string
for the "hevycli folder get" command) so the displayed usage matches the current
integer folder ID format.
- Around line 74-75: The code silently ignores the strconv.Atoi error when
parsing selected.ID into folderID which can leave folderID as 0; update the
parse to capture the error (e.g., val, err := strconv.Atoi(selected.ID)) and
handle it—either return the error up the call stack, log a clear message and
exit, or provide a safe fallback—so that malformed selected.ID is detected and
handled rather than silently defaulting folderID; reference the strconv.Atoi
call, the selected.ID value, and the folderID variable when implementing the
change.
In `@cmd/folder/update.go`:
- Line 84: The conversion of selected.ID with strconv.Atoi currently ignores the
error; change the code to capture the returned (id, err) from
strconv.Atoi(selected.ID) and handle err defensively (e.g., return the error
from the surrounding function or log and exit) before assigning folderID so the
program fails loudly if selected.ID is not a valid integer; update the folderID
assignment site to use the parsed id variable and ensure any error path provides
a clear message referencing selected.ID.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 76ff2b74-c7e2-4b45-b92c-38bbb9a4511d
📒 Files selected for processing (10)
.goreleaser.yamlcmd/folder/create.gocmd/folder/delete.gocmd/folder/get.gocmd/folder/list.gocmd/folder/update.gocmd/routine/get.gocmd/routine/list.gointernal/api/client.gointernal/api/types.go
- Revert goreleaser owner to obay to match go.mod module path - Update folder get examples to use integer IDs instead of UUIDs - Handle strconv.Atoi errors in folder get/delete/update interactive mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoutineResponse.Routinefrom singleRoutineto[]Routineto match the Hevy API which returns an array for theroutinefield in POST/PUT responsesCreateRoutineandUpdateRoutineto extract the first element from the arrayFixes #2
Test plan
go build ./...passesgo test ./...passeshevycli routine create --file routine.jsonsucceedshevycli routine updatesucceedsSummary by CodeRabbit
Bug Fixes
Chores