Web client wrongly attempts to reconnect to certain saved servers using insecure websockets on start, leading to error

[seisatsu]

The web client gives an error "The operation is insecure" and fails to automatically rejoin the Ergo Test Network server upon refreshing under the following circumstances:

1. Ergo Test Server was previously joined.
2. The page has since been refreshed.

Other servers in the sidebar will reconnect automatically upon rejoin. In addition, going back to the home page and manually joining Ergo again works. However, as long as Ergo Test Network is in the saved servers list in the sidebar, the error "The operation is insecure" (on Firefox specifically, but a similar error shows in Edge) will show in the connection dialog for all servers. Removing Ergo Test Network from the sidebar and refreshing removes the error.

In addition, the Firefox Developer Console shows the following errors:

• Failed to reconnect to server ws://testnet.ergo.chat:8097 DOMException: The operation is insecure.
• Uncaught (in promise) DOMException: The operation is insecure.

It appears that ObsidianIRC is mistakenly trying to connect to the Ergo Test Network using insecure websockets, even though this is a secure port. It is strange that this doesn't happen with other servers I tested in the welcome list.

I also tried running my own Ergo server and pointing the client to my own servers.json to connect, and I had the exact same symptoms.

See below attached screenshot from the obsidianirc.github.io client.

[seisatsu]

It looks like the function ensureUrlFormat() in src/store/index.ts called during reconnection to saved servers automatically marks a host as insecure ws:// if the port is not 6697, 9999, 443, or 993. The Ergo Test Network (and all Ergo installations by default) use 8097 as the secure websockets port, so this should probably be added to the list.

This is the function in question.

// Helper function to ensure host is in URL format
function ensureUrlFormat(host: string, port: number): string {
  if (host.includes("://")) {
    return host; // Already in URL format
  }
  // Convert old hostname-only format to URL
  const isLocalhost =
    host === "localhost" || host === "127.0.0.1" || host === "::1";
  const scheme = isLocalhost
    ? "ws"
    : port === 6697 || port === 9999 || port === 443 || port === 993
      ? "wss"
      : "ws";
  return `${scheme}://${host}:${port}`;
}

Adding 8097 to the list of wss ports on my hosted web client resolved the issue with my own Ergo server. (I tested by modifying the client to point to my own servers.json file.)

[seisatsu]

I opened pull request #140 to resolve this issue.

[ValwareIRC]

Thank you so much for your contribution!