fix #125

[matheusfillipe]

fixes #125
tested web and desktop build.

Summary by CodeRabbit

• Bug Fixes
  • Improved IRC server authentication flow to ensure SASL authentication completes successfully before finalizing capability negotiation, enhancing connection stability and reliability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[github-actions]

Preview URL: https://fix-sasl-auth.obsidianirc.pages.dev

Automated deployment preview for the PR in the Cloudflare Pages.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes enhance CAP (Capability) negotiation in the IRC client by making it SASL-aware. When SASL authentication is enabled and acknowledged, CAP END is deferred until SASL completes. This applies to three scenarios: CAP LS finalization, CAP END timeout handling, and final CAP ACK acknowledgment.

Changes

Cohort / File(s)	Change Summary
SASL-aware CAP negotiation src/lib/ircClient.ts	Enhanced CAP (Capability) negotiation with conditional SASL coordination. Defers CAP END when SASL is enabled and acknowledged across: (1) CAP LS finalization logic, (2) CAP END timeout handling, (3) final CAP ACK acknowledgment processing

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Oh CAP negotiations, now SASL aware!
The rabbit ensures protocols play fair,
No hasty goodbyes 'til auth is done,
A perfectly choreographed IRC run! ✨

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}