-
Notifications
You must be signed in to change notification settings - Fork 22
rebrand: docker image mattfly/obsidian -> mattfly/obby #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matheusfillipe
wants to merge
8
commits into
main
Choose a base branch
from
feat/h4ks-setup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3448014
Avatar and security fixes
matheusfillipe 19aef19
rebrand: docker image mattfly/obsidian -> mattfly/obby
matheusfillipe 5e4181b
docker: add workflow_dispatch trigger
matheusfillipe 07c273f
Merge branch 'main' of https://github.com/ObsidianIRC/ObsidianIRC int…
matheusfillipe f7085d0
switch docker images mattfly -> obbyirc
matheusfillipe 4aa2bd4
fix some live urls and voice channels placeholder message
matheusfillipe 1c4064c
supress pdf errors
matheusfillipe 5cd882e
better chat area copy
matheusfillipe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.security.device.audio-input</key> | ||
| <true/> | ||
| <key>com.apple.security.device.camera</key> | ||
| <true/> | ||
| </dict> | ||
| </plist> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>NSMicrophoneUsageDescription</key> | ||
| <string>ObsidianIRC uses the microphone for voice calls.</string> | ||
| <key>NSCameraUsageDescription</key> | ||
| <string>ObsidianIRC uses the camera for video calls.</string> | ||
| </dict> | ||
| </plist> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { Component, type ReactNode } from "react"; | ||
|
|
||
| // Stable reference: react-pdf reloads the document whenever the `options` prop | ||
| // is a new object, so this must never be reallocated per render. isEvalSupported | ||
| // is disabled to stop pdf.js from running eval() on untrusted document content. | ||
| export const PDF_OPTIONS = { isEvalSupported: false } as const; | ||
|
|
||
| /** | ||
| * react-pdf renders pages through pdf.js passive effects. When the surrounding | ||
| * Document unmounts (channel switch, StrictMode re-invoke) the worker transport | ||
| * is destroyed, but a still-pending Page effect can call into it and throw | ||
| * "Cannot read properties of null (reading 'sendWithPromise')". Without a | ||
| * boundary that throw is uncaught and takes down the whole app, so we catch it | ||
| * and let the caller fall back to a non-pdf.js renderer. | ||
| */ | ||
| export class PdfErrorBoundary extends Component< | ||
| { onError: () => void; children: ReactNode }, | ||
| { hasError: boolean } | ||
| > { | ||
| state = { hasError: false }; | ||
|
|
||
| static getDerivedStateFromError() { | ||
| return { hasError: true }; | ||
| } | ||
|
|
||
| componentDidCatch() { | ||
| this.props.onError(); | ||
| } | ||
|
|
||
| render() { | ||
| return this.state.hasError ? null : this.props.children; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
How to configure custom Info.plist in Tauri 2.11.1 bundle.macOS section?💡 Result:
To configure a custom Info.plist for a Tauri 2.11.1 macOS bundle, you should create a dedicated Info.plist file within your src-tauri directory and reference it in your tauri.conf.json configuration [1][2][3]. 1. Create a custom file: Create a file named Info.plist in your src-tauri folder and add your desired key-value pairs [1][3]. Example src-tauri/Info.plist: NSCameraUsageDescription Request camera access 2. Reference it in tauri.conf.json: Update your tauri.conf.json to point to this file under the bundle.macOS section using the infoPlist field [2]. { "bundle": { "macOS": { "infoPlist": "./Info.plist" } } } Tauri will merge the contents of this file with the default properties generated by the CLI [1]. Be cautious when overriding default values such as the application version or bundle identifier, as this can cause conflicts or unexpected behavior in your application bundle [1]. If you need to support multiple languages, create InfoPlist.strings files within language-specific.lproj directories and include them via the bundle.resources configuration [1]. Additionally, if your custom configuration requires Apple entitlements (such as security permissions), you should manage those separately in an entitlements file and reference it via the entitlements field in the same macOS bundle configuration block [3].
Citations:
Add
bundle.macOS.infoPlistreference for camera/mic usage descriptionsYou’re only setting
entitlementsinsrc-tauri/tauri.conf.json, and Tauri expects a custom Info.plist to be wired viabundle.macOS.infoPlist(e.g.,"infoPlist": "./Info.plist") to merge in keys likeNSMicrophoneUsageDescriptionandNSCameraUsageDescription. Without that explicit reference, the permission prompt strings may be missing.🤖 Prompt for AI Agents