Skip to content

[config] new testnet env vars BNB_TESTNET_WS_URL / BNB_TESTNET_HTTP_URL violate CHARON_* namespace convention #245

@obchain

Description

@obchain

PR: #51 (feat/23-testnet-config)
File: config/testnet.toml (new), .env.example
Refs #51

Problem

The PR description names the two new environment variables as BNB_TESTNET_WS_URL and BNB_TESTNET_HTTP_URL. These do not follow the CHARON_* prefix convention required for all env vars in this project.

Prior findings on this pattern:

The existing mainnet vars BNB_WS_URL / BNB_HTTP_URL in .env.example are also non-compliant (pre-existing gap). Adding two more in the same style compounds the technical debt.

Impact

In Docker Compose / Kubernetes environments with multiple service containers, bare BNB_TESTNET_* names risk collision with other services. The CHARON_ prefix is the namespace boundary that prevents this.

Fix

Rename the new vars to:

  • CHARON_BNB_TESTNET_WS_URL
  • CHARON_BNB_TESTNET_HTTP_URL

Update config/testnet.toml references accordingly. As part of this PR, also rename the pre-existing mainnet vars to CHARON_BNB_WS_URL and CHARON_BNB_HTTP_URL in .env.example and config/default.toml — all three files change atomically so operators have a single consistent namespace from this PR forward.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinglayer:rustRust crates (core / scanner / protocols / executor / cli)priority:p1-coreCore MVP scopestatus:readyScoped and ready to pick up

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions