PR: #51 (feat/23-testnet-config)
File: config/testnet.toml (new), .env.example
Refs #51
Problem
The PR description names the two new environment variables as BNB_TESTNET_WS_URL and BNB_TESTNET_HTTP_URL. These do not follow the CHARON_* prefix convention required for all env vars in this project.
Prior findings on this pattern:
The existing mainnet vars BNB_WS_URL / BNB_HTTP_URL in .env.example are also non-compliant (pre-existing gap). Adding two more in the same style compounds the technical debt.
Impact
In Docker Compose / Kubernetes environments with multiple service containers, bare BNB_TESTNET_* names risk collision with other services. The CHARON_ prefix is the namespace boundary that prevents this.
Fix
Rename the new vars to:
CHARON_BNB_TESTNET_WS_URL
CHARON_BNB_TESTNET_HTTP_URL
Update config/testnet.toml references accordingly. As part of this PR, also rename the pre-existing mainnet vars to CHARON_BNB_WS_URL and CHARON_BNB_HTTP_URL in .env.example and config/default.toml — all three files change atomically so operators have a single consistent namespace from this PR forward.
PR: #51 (feat/23-testnet-config)
File: config/testnet.toml (new), .env.example
Refs #51
Problem
The PR description names the two new environment variables as
BNB_TESTNET_WS_URLandBNB_TESTNET_HTTP_URL. These do not follow theCHARON_*prefix convention required for all env vars in this project.Prior findings on this pattern:
BSC_PRIVATE_RPC_URLmust beCHARON_BSC_PRIVATE_RPC_URLBOT_SIGNER_KEYmust beCHARON_SIGNER_KEYThe existing mainnet vars
BNB_WS_URL/BNB_HTTP_URLin.env.exampleare also non-compliant (pre-existing gap). Adding two more in the same style compounds the technical debt.Impact
In Docker Compose / Kubernetes environments with multiple service containers, bare
BNB_TESTNET_*names risk collision with other services. TheCHARON_prefix is the namespace boundary that prevents this.Fix
Rename the new vars to:
CHARON_BNB_TESTNET_WS_URLCHARON_BNB_TESTNET_HTTP_URLUpdate
config/testnet.tomlreferences accordingly. As part of this PR, also rename the pre-existing mainnet vars toCHARON_BNB_WS_URLandCHARON_BNB_HTTP_URLin.env.exampleandconfig/default.toml— all three files change atomically so operators have a single consistent namespace from this PR forward.