Skip to content

fix(grafana): satisfy dashboard-linter --strict #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obchain merged 3 commits into from
Apr 25, 2026
Merged

fix(grafana): satisfy dashboard-linter --strict #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3517b2c
fix(grafana): satisfy dashboard-linter --strict (closes #315)
obchain Apr 25, 2026
f4772a5
fix(grafana): make job template a multi-select
obchain Apr 25, 2026
8a52f12
ci(grafana-lint): fix promtool docker invocation
obchain Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/grafana-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:

- name: Validate alert rules with promtool
run: |
docker run --rm -v "$PWD/deploy/grafana:/rules:ro" \
docker run --rm --entrypoint=promtool \
-v "$PWD/deploy/grafana:/rules:ro" \
prom/prometheus:v2.55.1 \
promtool check rules /rules/alerts.yaml
check rules /rules/alerts.yaml
51 changes: 35 additions & 16 deletions deploy/grafana/charon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
]
},
"description": "Charon liquidation bot — scanner, executor, and profit telemetry. Scrapes the charon-metrics Prometheus exporter (default :9091). Chain/Instance variables default to All (.*) so panels render before the first scrape populates label_values; they auto-refine once metrics flow. Mempool / gas / RPC-latency panels deferred pending backing series: mempool #300, gas #301, rpc-latency #302. Alerting rules live in deploy/grafana/alerts.yaml.",
"editable": true,
"editable": false,
"fiscalYearStartMonth": 0,
"graphTooltip": 1,
"id": null,
Expand Down Expand Up @@ -53,7 +53,7 @@
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "sum by (chain) (rate(charon_scanner_blocks_total{instance=~\"$instance\",chain=~\"$chain\"}[1m]))",
"expr": "sum by (chain) (rate(charon_scanner_blocks_total{instance=~\"$instance\",chain=~\"$chain\",job=~\"$job\"}[$__rate_interval]))",
"legendFormat": "{{chain}}",
"range": true,
"refId": "A"
Expand All @@ -64,7 +64,7 @@
},
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"description": "Per-block pipeline wall-clock latency. p50 and p95 from the histogram. BSC produces a block every ~3s; quantiles use a [5m] range (~100 observations) so they stay stable across scrapes.",
"description": "Per-block pipeline wall-clock latency. p50 and p95 from the histogram. BSC produces a block every ~3s; quantiles use $__rate_interval (typically ~4× scrape interval) so they stay stable across scrapes while respecting the resolution Grafana selects for the current panel.",
"fieldConfig": {
"defaults": {
"color": { "mode": "palette-classic" },
Expand All @@ -90,15 +90,15 @@
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "histogram_quantile(0.5, sum by (le, chain) (rate(charon_pipeline_block_duration_seconds_bucket{instance=~\"$instance\",chain=~\"$chain\"}[5m])))",
"expr": "histogram_quantile(0.5, sum by (le, chain) (rate(charon_pipeline_block_duration_seconds_bucket{instance=~\"$instance\",chain=~\"$chain\",job=~\"$job\"}[$__rate_interval])))",
"legendFormat": "p50 {{chain}}",
"range": true,
"refId": "A"
},
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "histogram_quantile(0.95, sum by (le, chain) (rate(charon_pipeline_block_duration_seconds_bucket{instance=~\"$instance\",chain=~\"$chain\"}[5m])))",
"expr": "histogram_quantile(0.95, sum by (le, chain) (rate(charon_pipeline_block_duration_seconds_bucket{instance=~\"$instance\",chain=~\"$chain\",job=~\"$job\"}[$__rate_interval])))",
"legendFormat": "p95 {{chain}}",
"range": true,
"refId": "B"
Expand Down Expand Up @@ -139,7 +139,7 @@
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "sum by (bucket) (charon_scanner_positions{instance=~\"$instance\",chain=~\"$chain\"})",
"expr": "sum by (bucket) (charon_scanner_positions{instance=~\"$instance\",chain=~\"$chain\",job=~\"$job\"})",
"legendFormat": "{{bucket}}",
"range": true,
"refId": "A"
Expand Down Expand Up @@ -182,7 +182,7 @@
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "charon_executor_queue_depth{instance=~\"$instance\"}",
"expr": "charon_executor_queue_depth{instance=~\"$instance\",job=~\"$job\"}",
"legendFormat": "queue depth",
"range": true,
"refId": "A"
Expand Down Expand Up @@ -223,7 +223,7 @@
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "sum(increase(charon_executor_profit_usd_cents_sum{instance=~\"$instance\",chain=~\"$chain\"}[$__range])) / 100",
"expr": "sum(increase(charon_executor_profit_usd_cents_sum{instance=~\"$instance\",chain=~\"$chain\",job=~\"$job\"}[$__range])) / 100",
"legendFormat": "profit (selected range)",
"range": true,
"refId": "A"
Expand Down Expand Up @@ -264,7 +264,7 @@
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "sum by (result) (rate(charon_executor_simulations_total{instance=~\"$instance\",chain=~\"$chain\"}[1m])) * 60",
"expr": "sum by (result) (rate(charon_executor_simulations_total{instance=~\"$instance\",chain=~\"$chain\",job=~\"$job\"}[$__rate_interval])) * 60",
"legendFormat": "{{result}}",
"range": true,
"refId": "A"
Expand Down Expand Up @@ -301,15 +301,15 @@
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "label_replace(sum(rate(charon_executor_opportunities_queued_total{instance=~\"$instance\",chain=~\"$chain\"}[1m])) * 60, \"stage\", \"queued\", \"\", \"\")",
"expr": "label_replace(sum(rate(charon_executor_opportunities_queued_total{instance=~\"$instance\",chain=~\"$chain\",job=~\"$job\"}[$__rate_interval])) * 60, \"stage\", \"queued\", \"\", \"\")",
"legendFormat": "{{stage}}",
"range": true,
"refId": "A"
},
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "sum by (stage) (rate(charon_executor_opportunities_dropped_total{instance=~\"$instance\",chain=~\"$chain\"}[1m])) * 60",
"expr": "sum by (stage) (rate(charon_executor_opportunities_dropped_total{instance=~\"$instance\",chain=~\"$chain\",job=~\"$job\"}[$__rate_interval])) * 60",
"legendFormat": "{{stage}}",
"range": true,
"refId": "B"
Expand Down Expand Up @@ -353,7 +353,7 @@
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "sum by (le) (rate(charon_executor_profit_usd_cents_bucket{instance=~\"$instance\",chain=~\"$chain\"}[5m]))",
"expr": "sum by (le) (rate(charon_executor_profit_usd_cents_bucket{instance=~\"$instance\",chain=~\"$chain\",job=~\"$job\"}[$__rate_interval]))",
"format": "heatmap",
"legendFormat": "{{le}}",
"range": true,
Expand All @@ -367,7 +367,7 @@
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"description": "Running build metadata. Only `version` is surfaced; `git_sha` is intentionally hidden via transform exclusion until /metrics has auth (open #214) and LAN exposure is addressed (#213). Surfacing the exact SHA of a running binary to anyone with Grafana read access is an intelligence leak while those are unresolved.",
"fieldConfig": {
"defaults": { "custom": { "align": "auto" } },
"defaults": { "custom": { "align": "auto" }, "unit": "none" },
"overrides": []
},
"gridPos": { "h": 8, "w": 12, "x": 12, "y": 24 },
Expand All @@ -382,7 +382,7 @@
{
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"editorMode": "code",
"expr": "charon_build_info{instance=~\"$instance\"}",
"expr": "charon_build_info{instance=~\"$instance\",job=~\"$job\"}",
"format": "table",
"instant": true,
"legendFormat": "__auto",
Expand Down Expand Up @@ -424,6 +424,25 @@
"skipUrlSync": false,
"type": "datasource"
},
{
"allValue": ".+",
"current": { "selected": false, "text": "charon", "value": "charon" },
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"definition": "label_values(charon_build_info, job)",
"description": "Prometheus scrape job. Defaults to `charon`.",
"hide": 0,
"includeAll": true,
"label": "Job",
"multi": true,
"name": "job",
"options": [],
"query": { "query": "label_values(charon_build_info, job)", "refId": "StandardVariableQuery" },
"refresh": 2,
"regex": "",
"skipUrlSync": false,
"sort": 1,
"type": "query"
},
{
"allValue": ".*",
"current": { "selected": true, "text": "All", "value": "$__all" },
Expand All @@ -444,11 +463,11 @@
"type": "query"
},
{
"allValue": ".*",
"allValue": ".+",
"current": { "selected": true, "text": "All", "value": "$__all" },
"datasource": { "type": "prometheus", "uid": "${datasource}" },
"definition": "label_values(charon_build_info, instance)",
"description": "Instance label (Prometheus scrape target). Defaults to All (.*) so panels render before the first scrape populates the dropdown.",
"description": "Instance label (Prometheus scrape target). Defaults to All (.+) so panels render before the first scrape populates the dropdown.",
"hide": 0,
"includeAll": true,
"label": "Instance",
Expand Down
Loading