Conversation
ymarcon
reviewed
Dec 10, 2025
There was a problem hiding this comment.
Pull request overview
This PR adds support for writing binary (non-JSON) responses directly to stdout's buffer, allowing the REST command to handle file downloads and other binary content types. Previously, the code only handled JSON responses.
Key Changes:
- Added conditional logic to check the accept header and route binary responses to
sys.stdout.buffer.write() - Preserved existing JSON response handling with formatting options
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 13 commits
December 10, 2025 17:45
kazoompa
force-pushed
the
bugfix/accept-binary
branch
2 times, most recently
from
5f88a4f to
00ec66c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.