Consolidate per-command daemon-error enums into shared DaemonToolError#110
Merged
obj-p merged 1 commit intocli-mcp-parityfrom Apr 15, 2026
Merged
Consolidate per-command daemon-error enums into shared DaemonToolError#110obj-p merged 1 commit intocli-mcp-parityfrom
obj-p merged 1 commit intocli-mcp-parityfrom
Conversation
Every daemon-client command had its own single-case XxxCommandError.daemonError(String) with an identical description implementation — 8 copies of the same enum across ~80 lines. Replace them with one shared DaemonToolError in DaemonToolError.swift: - ElementsCommandError, SwitchCommandError, ConfigureCommandError, TouchCommandError, SimulatorsCommandError, StopCommandError, VariantsCommandError: deleted. All throw sites now use DaemonToolError.daemonError. - SnapshotCommandError keeps its two snapshot-specific cases (invalidImageData, noImageContent). Its daemon-error throws are redirected through DaemonToolError. No behavior change — the thrown messages are byte-for-byte identical because both enums just surface the daemon's text verbatim. All 41 tests across the 7 daemon-client suites pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every daemon-client command had its own single-case
XxxCommandError.daemonError(String)with an identicaldescriptionimplementation — 8 copies of the same enum across ~80 lines. Replaces them with one sharedDaemonToolError.ElementsCommandError,SwitchCommandError,ConfigureCommandError,TouchCommandError,SimulatorsCommandError,StopCommandError,VariantsCommandError.SnapshotCommandErrorkeeps its two snapshot-specific cases (invalidImageData,noImageContent) but its daemon-error throws now route throughDaemonToolError.Net: +32 / -77 lines. No behavior change — the thrown messages are byte-for-byte identical.
Test plan
swift buildswift test --filter 'ElementsCommandTests|SwitchCommandTests|ConfigureCommandTests|TouchCommandTests|SimulatorsCommandTests|StopCommandTests|VariantsCommandTests'(41 tests across 7 suites, all green, ~2m)🤖 Generated with Claude Code