Allow font creation to fail and fallback to a safe font#5
Merged
chriseidhof merged 1 commit intoobjcio:mainfrom Jul 5, 2023
Merged
Allow font creation to fail and fallback to a safe font#5chriseidhof merged 1 commit intoobjcio:mainfrom
chriseidhof merged 1 commit intoobjcio:mainfrom
Conversation
Member
Author
|
|
onevcat
force-pushed
the
fix/optional-font
branch
from
11a7cb0 to
487e399
Compare
Contributor
|
This makes sense, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some languages (such as CJK), there is no "italic" version of the font. For these fonts, if the
traitscontains.italic,NSFont.init(descriptor:size:)will fail to create the font and returnnil.I understand that it can be an "author error" to use a font without italic version, but use
*some word*to make text italic. But I guess a hard crash for this error is too strict. Unless modifying every italic case in the original text, I won't be able to use a new font, which is not ideal and painful.