Skip to content

Conversation

@vaind
Copy link
Contributor

@vaind vaind commented Oct 27, 2020

Adds sync client support following the same API as in line with other language bindings. Currently, tests are rather limited as they require a special sync-enabled runtime library.

TODOs:

  • Requires next c-api (v0.11) for obx_sync_available()
  • sync annotation
  • test with an actual sync server
  • integrate with sync-enabled Android/iOS objectbox packages
  • docs updates
  • [postponed] listeners

@vaind vaind changed the title Sync Sync client Oct 27, 2020
@vaind
Copy link
Contributor Author

vaind commented Nov 2, 2020

@greenrobot-team please have an overall look. I don't expect any major changes, with listeners postponed to a next issue.

Copy link
Member

@greenrobot-team greenrobot-team left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicking comments. LGTM otherwise!

@vaind vaind mentioned this pull request Nov 3, 2020
@vaind vaind force-pushed the sync branch 9 times, most recently from fc11d37 to adec14d Compare November 6, 2020 17:20
@greenrobot-team
Copy link
Member

Latest changes LGTM.

@vaind vaind marked this pull request as ready for review November 9, 2020 18:46
@vaind vaind merged commit a9f4966 into main Nov 9, 2020
@vaind vaind deleted the sync branch November 9, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants