add openStore() to the generated code #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenrobot
reviewed
Jun 23, 2021
Member
greenrobot-team
left a comment
greenrobot-team
left a comment
There was a problem hiding this comment.
Potential issue. Otherwise LGTM.
| // build() will be called only twice, once for the `lib` directory and once for the `test` directory | ||
| Pubspec? pubspec; | ||
| try { | ||
| final pubspecFile = File(path.join(dir(buildStep), '../pubspec.yaml')); |
Member
There was a problem hiding this comment.
Not that familiar with pubspec, but can the flutter libs dependency also come from another file (external variable or import)? Or put differently: can this fail to find flutter libs, even though it's a dependency?
Contributor
Author
There was a problem hiding this comment.
I don't know of any other way (which doesn't mean there isn't any, though I doubt it). But it's fine even if it fails - you would just get the plain dart's openStore() version and would have to try and figure out why it doesn't open the directory, potentially creating a GH issue here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130