Conversation
added 20 commits
June 18, 2020 17:54
vaind
force-pushed
the
conditional-test-compilation
branch
from
af4db6b to
ea45674
Compare
Member
greenrobot-team
left a comment
greenrobot-team
left a comment
There was a problem hiding this comment.
My cmake/C++ knowledge is limited, so e.g. can't say if the TestLibExists/LibraryExists stuff always works, but it looks simple enough.
LGTM otherwise.
Member
|
I quickly "flew over" the changes and nothing struck me. Anything in particular you want me have a closer look at? |
Contributor
Author
Nothing special, It's a test code after all and in line with the issue description |
Member
|
OK, then... Merge at your convenience |
dan-obx
added a commit
that referenced
this pull request
Mar 1, 2024
Resolve "Add C++ 11 option" Closes #6 See merge request objectbox/objectbox-generator!4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2