Bugfix 2116/email export mishandles commas #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into bugfix-2116/email-export-mishandles-commas # Conflicts: # server/src/test/java/com/objectcomputing/checkins/services/fixture/RepositoryFixture.java
… on Menu and TransferList
…into bugfix-2116/email-export-mishandles-commas
…into bugfix-2116/email-export-mishandles-commas
mkimberlin
approved these changes
Mar 27, 2024
Member
mkimberlin
left a comment
mkimberlin
left a comment
There was a problem hiding this comment.
Approving...because I think I answered my own confusion. However, I am curious about why you needed to do both mock tests and e2e tests.
server/src/test/java/com/objectcomputing/checkins/services/TestContainersSuite.java
Show resolved
Hide resolved
borinquenkid
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implemented member export service. Removed react-csv dependency from web-ui.
To test:
Closes #2116