Feature 2136 / Migrate permission entity #2161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor security filters and RolePermissionServices to use Permission enum - Migration to drop composit key for role_permission table - Updates to test fixtures
- Refactor security filters and RolePermissionServices to use Permission enum - Migration to drop composit key for role_permission table - Updates to test fixtures
# Conflicts: # server/src/main/java/com/objectcomputing/checkins/security/permissions/Permissions.java # server/src/main/java/com/objectcomputing/checkins/services/memberprofile/csvreport/MemberProfileReportController.java # server/src/main/java/com/objectcomputing/checkins/services/permissions/Permission.java # server/src/main/resources/db/dev/R__Load_testing_data.sql # server/src/test/java/com/objectcomputing/checkins/services/fixture/PermissionFixture.java # server/src/test/java/com/objectcomputing/checkins/services/fixture/RepositoryFixture.java # server/src/test/java/com/objectcomputing/checkins/services/role/role_permissions/RolePermissionsControllerTest.java
- Fixes to tests
Collaborator
Author
|
@mkimberlin Migration has been updated to copy over role_permission records to the new table structure |
mkimberlin
previously approved these changes
Apr 2, 2024
Member
mkimberlin
left a comment
mkimberlin
left a comment
There was a problem hiding this comment.
I feel like this covers the server side pretty well...now what will break on the frontend? Just permission management screen maybe? I think it keys off of the ids
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
pieperm
reviewed
Apr 10, 2024
...m/objectcomputing/checkins/services/memberprofile/currentuser/CurrentUserControllerTest.java
Show resolved
Hide resolved
...m/objectcomputing/checkins/services/memberprofile/currentuser/CurrentUserControllerTest.java
Show resolved
Hide resolved
...m/objectcomputing/checkins/services/memberprofile/currentuser/CurrentUserControllerTest.java
Outdated
Show resolved
Hide resolved
pieperm
approved these changes
Apr 10, 2024
mkimberlin
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates away from the Permission entity class and replaces it with consistent using of the Permissions enum. The goal is to simplify the persistence around permissions/role permissions.
More details: #2136
Many updates were made to test fixtures to get the test suite working. Functionality should not be greatly changed except for the loss of the permission id (UUID).