Bugfix 2165/member export report not working #2176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieperm
requested review from
Richardson-e,
S78901,
Samibanley,
ZacharyKlein,
borinquenkid,
mkimberlin and
weiqigao
mkimberlin
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2165
After testing out the front-end APIs, I determined that the problem originated from transitioning from axios to fetch. In axios, specifying a
responseTypeofblobwould convert the response payload to a Blob object, which is then passed to the file downloader. With fetch, this conversion has to be done manually, but the implementation was only handling JSON and text responses. This modifies theresolvemethod to return a blob in the payload if the "Content-Type" header is "text/csv".An alternative fix could be to include
responseTypein the request payload and determine the datatype for the response payload based on that, similar to axios.