[2115] Dynamic Role Stats & Update yarn #2177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
S78901
requested review from
Richardson-e,
Samibanley,
ZacharyKlein,
borinquenkid,
mkimberlin and
pieperm
S78901
assigned
S78901,
mkimberlin,
ZacharyKlein,
pieperm and
Samibanley and unassigned
S78901
pieperm
reviewed
Apr 5, 2024
Collaborator
There was a problem hiding this comment.
While reviewing this, I noticed that the snapshot for this page does not include the cards that display the members in each role. It might be worthwhile to fix that as part of this issue. I believe this could be fixed by adding userRoles to the initial state in Roles.test.jsx
Samibanley
approved these changes
Apr 9, 2024
pieperm
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to:
#2115