Skip to content

Fix snapshot test that has async state updates #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2024
Merged

Fix snapshot test that has async state updates #2183

merged 3 commits into from
Apr 9, 2024

Conversation

@mkimberlin
Copy link
Member

@mkimberlin mkimberlin commented Apr 9, 2024

No description provided.

S78901
S78901 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@S78901 S78901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mkimberlin mkimberlin merged commit 4442bf8 into develop Apr 9, 2024
@mkimberlin mkimberlin deleted the feature-2182/fix-edit-skills-card-test branch April 9, 2024 21:53
@mkimberlin mkimberlin linked an issue Apr 11, 2024 that may be closed by this pull request
Fix edit skills card snapshot #2182
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieperm pieperm pieperm approved these changes

@borinquenkid borinquenkid Awaiting requested review from borinquenkid

@Samibanley Samibanley Awaiting requested review from Samibanley

+1 more reviewer

@S78901 S78901 S78901 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix edit skills card snapshot

4 participants

@mkimberlin @pieperm @S78901