Bugfix 2191/fix permission serialization #2192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkimberlin
requested review from
Richardson-e,
S78901,
Samibanley,
ZacharyKlein,
borinquenkid and
pieperm
borinquenkid
approved these changes
Apr 12, 2024
Collaborator
borinquenkid
left a comment
borinquenkid
left a comment
There was a problem hiding this comment.
Only question is why Permission and PermissionDTO
S78901
approved these changes
Apr 12, 2024
Member
Author
Because that is the fastest path to getting the APIs to serialize the way that is currently needed. Permissions need to be serialized one way in one case and another in another case. I think ultimately it will be cleaner to not use the Permission object in the APIs directly at all, but I'm not going to take that on before the demo. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.