Feature 2190/replace transfer list on email page with member selector #2193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieperm
requested review from
Richardson-e,
S78901,
Samibanley,
ZacharyKlein,
borinquenkid,
mkimberlin and
weiqigao
Member
|
This loses us the export of the list, currently. Doesn't it? |
Collaborator
Author
This has been fixed by the most recent commits. The |
mkimberlin
previously approved these changes
Apr 17, 2024
This was referenced Apr 17, 2024
…into feature-2190/replace-transfer-list-on-email-page-with-member-selector # Conflicts: # web-ui/src/components/member_selector/MemberSelector.jsx
mkimberlin
approved these changes
Apr 18, 2024
S78901
approved these changes
Apr 19, 2024
mkimberlin
deleted the
feature-2190/replace-transfer-list-on-email-page-with-member-selector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Email page to use the new MemberSelector component in place of the transfer list for selecting recipients. There's also a small fix in here for the MemberSelectorDialog, which was sometimes not populating the list of members when reopening the dialog.
Note: This PR also removes the TransferList component. We could opt to keep it around in case it finds a use in the future.
To test:
I could not get the emails to actually send due to an internal server error on the back-end, but the list of recipients sent to the server seems to be correct.
Closes #2190