Feature 2232 eslint integration #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
commented
Apr 24, 2024
| @@ -0,0 +1,36 @@ | |||
| import globals from "globals"; | |||
Collaborator
Author
There was a problem hiding this comment.
It took a few hours to arrive at this config!
mvolkmann
commented
Apr 24, 2024
| "coverage": "vitest run --coverage --watch=false", | ||
| "format": "prettier --write 'src/**/*.{css,html,js,jsx}'", | ||
| "format": "prettier --write 'src/**/*.{css,html,js,jsx,ts,tsx}'", | ||
| "lint": "eslint --fix --quiet", |
Collaborator
Author
There was a problem hiding this comment.
New script to run ESLint.
mvolkmann
commented
Apr 24, 2024
| periods | ||
| .sort((a, b) => { | ||
| return !!a.open === !!b.open | ||
| return Boolean(a.open) === Boolean(b.open) |
Collaborator
Author
There was a problem hiding this comment.
ESLint likes this better.
mvolkmann
commented
Apr 24, 2024
| import renderer from 'react-test-renderer'; | ||
| import SkeletonLoader from './SkeletonLoader'; | ||
|
|
||
| it("renders correctly when 'team' is passed as prop ", () => { |
Collaborator
Author
There was a problem hiding this comment.
ESLint removed the extra space at the ends of these description strings.
mvolkmann
commented
Apr 24, 2024
| }); | ||
|
|
||
| it("renders correctly when 'feedback_requests' is passed as prop ", () => { | ||
| it("renders correctly when 'received_requests' is passed as prop", () => { |
Collaborator
Author
There was a problem hiding this comment.
The previous description string was repeated several times.
mvolkmann
commented
Apr 24, 2024
| ); | ||
| expect(component.toJSON()).toMatchSnapshot(); | ||
| }); | ||
| it("renders correctly when 'feedback_requests' is passed as prop ", () => { |
Collaborator
Author
There was a problem hiding this comment.
This was a duplicate test.
mvolkmann
commented
Apr 24, 2024
| @@ -1,6 +1,6 @@ | |||
| // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html | |||
|
|
|||
| exports[`renders correctly when 'feedback_requests' is passed as prop 1`] = ` | |||
Collaborator
Author
There was a problem hiding this comment.
This snapshot file was updated to match the test updates.
mkimberlin
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.