Feature 2242 download members #2245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
commented
Apr 25, 2024
| @@ -1,17 +1,20 @@ | |||
| import fileDownload from 'js-file-download'; | |||
Collaborator
Author
There was a problem hiding this comment.
Much of the new code in this file was moved here from Menu.jsx.
mvolkmann
commented
Apr 25, 2024
| <Button startIcon={<PersonIcon />} onClick={handleOpen}> | ||
| Add Member | ||
| </Button> | ||
| {selectHasProfileReportPermission(state) && ( |
Collaborator
Author
There was a problem hiding this comment.
This part adds the new button if the user has the required permission.
mvolkmann
commented
Apr 25, 2024
| import React, { useContext, useEffect, useRef, useState } from 'react'; | ||
|
|
||
| import { postEmployeeHours } from '../../api/hours'; | ||
| import { reportAllMembersCsv } from '../../api/member'; |
Collaborator
Author
There was a problem hiding this comment.
All the deleted lines moved to Users.jsx above.
mvolkmann
commented
Apr 25, 2024
| ) | ||
| ); | ||
|
|
||
| export const selectHasProfileReportPermission = createSelector( |
Collaborator
Author
There was a problem hiding this comment.
This is a new permission check that is used in Users.jsx.
mkimberlin
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.