moved "Upload Hours" button from avatar menu to ADMIN menu #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
commented
Apr 25, 2024
| </ListItem> | ||
| <Collapse in={adminOpen} timeout="auto" unmountOnExit> | ||
| {createListJsx(adminLinks, true)} | ||
| {isAdmin && ( |
Collaborator
Author
There was a problem hiding this comment.
This code was moved here from below.
I had to customize the styling of the button to match the look of the links in the ADMIN menu.
Member
There was a problem hiding this comment.
Any reason not to just make it a <ListItem> like the others?
Collaborator
Author
There was a problem hiding this comment.
I didn't realize I could attach an onClick to a ListItem. I pushed that change.
mvolkmann
commented
Apr 25, 2024
| {isAdmin && ( | ||
| <MenuItem | ||
| onClick={() => { | ||
| closeAvatarMenu(); |
Collaborator
Author
There was a problem hiding this comment.
I didn't need the call to closeAvatarMenu above since the button is no longer in that menu.
S78901
previously approved these changes
Apr 25, 2024
vhscom
previously approved these changes
Apr 25, 2024
Contributor
vhscom
left a comment
vhscom
left a comment
There was a problem hiding this comment.
Looks good to me. I see button prop on ListItem is deprecated.
Collaborator
Author
I removed those deprecated props. |
mkimberlin
previously approved these changes
Apr 25, 2024
mkimberlin
previously approved these changes
Apr 25, 2024
mkimberlin
approved these changes
Apr 25, 2024
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.