fix: parse tsx files with the tseslint parser #2247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
reviewed
Apr 25, 2024
mvolkmann
reviewed
Apr 25, 2024
mvolkmann
reviewed
Apr 25, 2024
| eslint-visitor-keys "^3.3.0" | ||
|
|
||
| "@eslint-community/regexpp@^4.6.1": | ||
| "@eslint-community/regexpp@^4.10.0", "@eslint-community/regexpp@^4.6.1": |
Collaborator
There was a problem hiding this comment.
Are we using two versions of this same package?
Contributor
Author
There was a problem hiding this comment.
We're not, but one of our transient dependencies may be.
vhscom
force-pushed
the
fix/eslint-errors-typescript
branch
3 times, most recently
from
4387b6d to
a713cb2
Compare
vhscom
force-pushed
the
fix/eslint-errors-typescript
branch
from
4ad0096 to
3db9095
Compare
mvolkmann
reviewed
Apr 26, 2024
ZacharyKlein
previously approved these changes
Apr 26, 2024
mvolkmann
previously approved these changes
Apr 26, 2024
vhscom
dismissed stale reviews from jackkeller, mvolkmann, and ZacharyKlein
via
9e65f52
ZacharyKlein
approved these changes
Apr 26, 2024
mvolkmann
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for TSX parsing and documents type used given ESLint now has two config types. Information about the new FlatConfig from Nicholas Zakas can be found here: https://eslint.org/blog/2022/08/new-config-system-part-2/
Ref: https://typescript-eslint.io/packages/typescript-eslint/ on the set-up.