Skip to content

Conversation

@S78901
Copy link
Contributor

@S78901 S78901 commented Apr 26, 2024

Screenshot 2024-04-26 at 12 58 59 PM

@S78901 S78901 linked an issue Apr 26, 2024 that may be closed by this pull request
4 tasks
@S78901
Copy link
Contributor Author

S78901 commented Apr 26, 2024

@mkimberlin Please review information and the image in the description to verify that this is what you had in mind.

@S78901 S78901 self-assigned this Apr 26, 2024
@S78901 S78901 marked this pull request as ready for review April 26, 2024 18:05
@mkimberlin
Copy link
Member

@mkimberlin Please review information and the image in the description to verify that this is what you had in mind.

Apologies. I gave insufficient AC because I was so deeply mired in looking at all these stories together. I have added an AC that clarifies the status values this needs to support.

@S78901
Copy link
Contributor Author

S78901 commented May 3, 2024

@mkimberlin Please review the new specs and let me know if this is what you were envisioning.

Screenshot 2024-05-03 at 11 58 22 AM

@mkimberlin
Copy link
Member

@mkimberlin Please review the new specs and let me know if this is what you were envisioning.

Screenshot 2024-05-03 at 11 58 22 AM

Looks perfect.

index = i;
}
});
setActiveIndex(toInteger(index));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't index already an integer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we don't need this anymore.

const [activeIndex, setActiveIndex] = useState(0);

useEffect(() => {
let index = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a shorter way to do this. Maybe something like this:

const index = optionsArr.findIndex(opt => opt.option === revPeriod);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked fine, thanks for the suggestion.

Copy link
Collaborator

@jackkeller jackkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Approved! 🌟

@mkimberlin mkimberlin merged commit 5103bcc into develop May 7, 2024
@mkimberlin mkimberlin deleted the feature-2220/stepper-review-status-admin branch May 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create review status stepper component

5 participants