-
Notifications
You must be signed in to change notification settings - Fork 6
Feature 2220/stepper review status admin #2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
S78901
commented
Apr 26, 2024
|
@mkimberlin Please review information and the image in the description to verify that this is what you had in mind. |
Apologies. I gave insufficient AC because I was so deeply mired in looking at all these stories together. I have added an AC that clarifies the status values this needs to support. |
…er-review-status-admin
|
@mkimberlin Please review the new specs and let me know if this is what you were envisioning.
|
Looks perfect. |
| index = i; | ||
| } | ||
| }); | ||
| setActiveIndex(toInteger(index)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't index already an integer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we don't need this anymore.
| const [activeIndex, setActiveIndex] = useState(0); | ||
|
|
||
| useEffect(() => { | ||
| let index = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a shorter way to do this. Maybe something like this:
const index = optionsArr.findIndex(opt => opt.option === revPeriod);There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked fine, thanks for the suggestion.
jackkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Approved! 🌟
