Skill Categories page now gets settings from query parameters #2272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S78901
previously approved these changes
Apr 26, 2024
mvolkmann
commented
Apr 29, 2024
| <input | ||
| id="all-skills" | ||
| type="checkbox" | ||
| value="false" |
Collaborator
Author
There was a problem hiding this comment.
We are using the checked property now instead of the value property.
mvolkmann
commented
Apr 29, 2024
| <input | ||
| id="all-skills" | ||
| type="checkbox" | ||
| value="false" |
Collaborator
Author
There was a problem hiding this comment.
We are using the checked property now instead of the value property.
mvolkmann
commented
Apr 29, 2024
| @@ -1,10 +1,11 @@ | |||
| import React, { useContext, useState } from 'react'; | |||
| import { Link } from 'react-router-dom'; | |||
Collaborator
Author
There was a problem hiding this comment.
This was just moved up a few lines.
mvolkmann
commented
Apr 29, 2024
| <label htmlFor="all-skills">Show all skills</label> | ||
| <input | ||
| onClick={handleClick} | ||
| onChange={handleClick} |
Collaborator
Author
There was a problem hiding this comment.
It's recommended to use onChange with checkboxes instead of onClick.
mvolkmann
commented
Apr 29, 2024
| @@ -1,38 +1,37 @@ | |||
| import React, { useCallback, useContext, useEffect, useState } from 'react'; | |||
| import { styled } from '@mui/material/styles'; | |||
Collaborator
Author
There was a problem hiding this comment.
I reordered several of the imports.
mvolkmann
commented
Apr 29, 2024
| const [query, setQuery] = useState(''); | ||
| const [skillFilter, setSkillFilter] = useState(null); | ||
|
|
||
| useQueryParameters([ |
Collaborator
Author
There was a problem hiding this comment.
This adds support for maintaining state with query parameters.
mvolkmann
commented
Apr 29, 2024
|
|
||
| const handleClick = () => setShowAllSkills(!showAllSkills); | ||
|
|
||
| useQueryParameters([ |
Collaborator
Author
There was a problem hiding this comment.
This adds support for maintaining state with query parameters.
vhscom
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.