refactor: isolate expand button logic into component #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhscom
commented
Apr 30, 2024
| </IconButton> | ||
| <ExpandMore | ||
| expand={expanded} | ||
| onClick={handleExpandClick} |
Contributor
Author
There was a problem hiding this comment.
Expansion logic moved into handler function rather than modifying state directly.
vhscom
commented
Apr 30, 2024
| [`& .${classes.expandOpen}`]: { | ||
| transform: 'rotate(180deg)', | ||
| transition: 'transform 0.1s linear', | ||
| marginLeft: 'auto' |
Contributor
Author
There was a problem hiding this comment.
This is styled component logic which was being used to replicate the animated behavior of the icon.
mvolkmann
reviewed
Apr 30, 2024
mvolkmann
reviewed
Apr 30, 2024
web-ui/src/components/feedback_request_card/FeedbackRequestCard.jsx
Outdated
Show resolved
Hide resolved
mvolkmann
reviewed
Apr 30, 2024
mvolkmann
reviewed
Apr 30, 2024
mvolkmann
reviewed
Apr 30, 2024
vhscom
force-pushed
the
feature-2212/expand-more-component
branch
3 times, most recently
from
5ca1266 to
4357538
Compare
vhscom
force-pushed
the
feature-2212/expand-more-component
branch
from
7c4dc96 to
fa14fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of #2212, which requires "expandable section with a summary" I found an opportunity to DRY up our codebase. This pull removes custom styling used in multiple places to produce an
ExpandMorebutton which abstracts away the animation logic, refactors current usage in the codebase and leverages Testing Library to perform snapshot-free tests on the component, to validate its core logic and capabilities.Screen.Recording.2024-04-30.at.1.44.08.PM.mov