story 2310: added use of query parameters in ReviewPeriods.jsx #2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
commented
May 3, 2024
| import UnarchiveIcon from '@mui/icons-material/Unarchive'; | ||
| import WorkIcon from '@mui/icons-material/Work'; | ||
|
|
||
| import Box from '@mui/material/Box'; |
Collaborator
Author
There was a problem hiding this comment.
I combined these imports into one.
mvolkmann
commented
May 3, 2024
|
|
||
| useQueryParameters([ | ||
| { | ||
| name: 'add', |
Collaborator
Author
There was a problem hiding this comment.
The only state I see that we can track with query parameters on this page is whether the "ADD REVIEW PERIOD" button was clicked.
mvolkmann
commented
May 3, 2024
| periodId => { | ||
| if (mode === 'self') { | ||
| if ( | ||
| selectReviewPeriod(state, periodId)?.reviewStatus === ReviewStatus.OPEN |
Collaborator
Author
There was a problem hiding this comment.
Prettier did this.
mvolkmann
commented
May 3, 2024
| key={`period-lit-${id}`} | ||
| onClick={() => onPeriodClick(id)} | ||
| primary={ | ||
| name + (reviewStatus === ReviewStatus.OPEN ? ' - Open' : '') |
Collaborator
Author
There was a problem hiding this comment.
Prettier did this.
mvolkmann
changed the title
vhscom
approved these changes
May 6, 2024
mkimberlin
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.