Bugfix 2227/fixing serialization of local date time #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ZacharyKlein
approved these changes
May 3, 2024
S78901
approved these changes
May 3, 2024
Contributor
|
You may want to check on the Gradle build failure. |
…into bugfix-2227/fixing-serialization-of-local-date-time
Collaborator
Author
Failing tests are from a commit on develop that I mentioned earlier. |
…into bugfix-2227/fixing-serialization-of-local-date-time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing LocalDateTime serialization issue that was found here: #2277
In the future it is probably simpler to set this format globally using jackson.date-format configuration setting, but that has the potential to cause issues across other APIs and would require more extensive testing. I think this path is good for now to get Syd unblocked, then maybe write up a ticket to look into that.