Feature 2233/theme cherry picks #2335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jackkeller
commented
May 7, 2024
jackkeller
commented
- redid commits for this story
- adds _variables.css file to control theming natively
- overwrites a few things in App.jsx where native css variables were not doing the trick
- removes hardcoded color variables throughout the site
- makes a11y happy with contrast and most general things
mvolkmann
reviewed
May 7, 2024
mvolkmann
reviewed
May 7, 2024
mvolkmann
reviewed
May 7, 2024
mvolkmann
reviewed
May 7, 2024
mvolkmann
reviewed
May 7, 2024
vhscom
approved these changes
May 7, 2024
Contributor
vhscom
left a comment
vhscom
left a comment
There was a problem hiding this comment.
Looks good to me. Left a couple comments.
web-ui/src/components/received_request_card/ReceivedRequestCard.jsx
Outdated
Show resolved
Hide resolved
mvolkmann
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.