Feature 2345/update pulse response object #2351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
S78901
requested review from
devaughns,
mjperry91,
mkimberlin,
mvolkmann and
vhscom
mjperry91
approved these changes
May 10, 2024
…ithub.com/objectcomputing/check-ins into feature-2345/update-pulse-response-object
devaughns
approved these changes
May 10, 2024
Contributor
Author
|
@mkimberlin Please give this an eyeball/approval before I merge. |
mkimberlin
reviewed
May 10, 2024
server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponse.java
Outdated
Show resolved
Hide resolved
| @NotNull | ||
| @Schema(required = true, description = "date for updatedDate") | ||
| private LocalDate updatedDate; | ||
| @Schema(required = true, description = "integer value of external score") |
Member
There was a problem hiding this comment.
I think we should make external scores and feelings nullable. That would mean changing the field below this as well. We definitely want both feelings to be nullable. Those are comments. The only thing that I think we want to require is a score on the "internal" (about work) feelings.
Member
There was a problem hiding this comment.
Almost what I meant... There are three fields that should be nullable: internalFeelings, externalScore, and externalFeelings
internalScore should not be nullable.
Contributor
Author
|
@mkimberlin please review the changes |
…e-pulse-response-object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to:
#2345