Feature 2284 review period employees #2358
Conversation
…iew-period-employees
…iew-period-employees
| } | ||
|
|
||
| .member-selector-card .member-selector-card-title { | ||
| font-size: 1.5em; |
There was a problem hiding this comment.
Adjusted some font sizes to improve UI.
| Avatar, | ||
| Card, | ||
| CardHeader, | ||
| Collapse, |
There was a problem hiding this comment.
Lots of UI functionality was removed from this component per Michael.
We no longer display a list of the selected members and only display the number of selected members.
|
|
||
| const addMembers = membersToAdd => { | ||
| onChange([...selected, ...membersToAdd]); | ||
| const replaceSelectedMembers = members => { |
There was a problem hiding this comment.
We now replace the complete set of selected members rather than adding to it.
| onSelect={handleNewRequest} | ||
| onClose={handleCloseNewRequest} | ||
| /> | ||
| <MemberSelectorDialog |
There was a problem hiding this comment.
This is used to display the team members associated with this review period.
It also allows more to be added and existing selections to be removed.
| onClose={() => setDialogOpen(false)} | ||
| onSubmit={membersToAdd => setTeamMembers(membersToAdd)} | ||
| /> | ||
| <Dialog |
There was a problem hiding this comment.
This is used for confirmation before a review period can be deleted.
| @@ -1,7 +1,8 @@ | |||
| import dayjs from 'dayjs'; | |||
There was a problem hiding this comment.
This seems to be required for passing dates to the MUI DatePicker component.
| @@ -1,7 +1,8 @@ | |||
| import dayjs from 'dayjs'; | |||
| import React, { useRef, useEffect, useState } from 'react'; | |||
| import { LocalizationProvider } from '@mui/x-date-pickers/LocalizationProvider'; | |||
There was a problem hiding this comment.
This was just moved down a few lines.
| import React, { useCallback, useContext, useEffect, useState } from 'react'; | ||
|
|
||
| import { | ||
| Archive, |
There was a problem hiding this comment.
Lots of UI functionality was moved from this component to TeamReviews.jsx.
| } | ||
| key={`period-${id}`} | ||
| > | ||
| <ListItem key={`period-${id}`}> |
There was a problem hiding this comment.
This simpler ListItem replaces the one above.
| export const ADD_TEAM = '@@check-ins/add_team'; | ||
| export const DELETE_MEMBER_PROFILE = '@@check-ins/delete_member_profile'; | ||
| export const DELETE_MEMBER_SKILL = '@@check-ins/delete_member_skill'; | ||
| export const DELETE_REVIEW_PERIOD = '@@check-ins/delete_review_period'; |
There was a problem hiding this comment.
Two new actions were added.
| state.guilds.sort((a, b) => a.name.localeCompare(b.name)); | ||
| state.guilds = [...state.guilds]; | ||
| break; | ||
| case UPDATE_REVIEW_PERIODS: |
There was a problem hiding this comment.
This was just moved down.
| case ADD_REVIEW_PERIOD: | ||
| state.reviewPeriods = [...state.reviewPeriods, action.payload]; | ||
| break; | ||
| case DELETE_REVIEW_PERIOD: |
There was a problem hiding this comment.
Two new actions were implemented.
| title="Select PDLs" | ||
| selected={selectedPdls} | ||
| onChange={setSelectedPdls} | ||
| listHeight={180} |
There was a problem hiding this comment.
This prop is no longer needed.
| <div className="team-skill-report-page"> | ||
| <MemberSelector | ||
| className="team-skill-member-selector" | ||
| listHeight={300} |
There was a problem hiding this comment.
This prop is no longer needed.
| Tooltip, | ||
| Typography | ||
| } from '@mui/material'; | ||
| import AddIcon from '@mui/icons-material/Add'; |
There was a problem hiding this comment.
Some of these icons are no longer used and access to the ones that are was simplified by using their given names.
| ) : ( | ||
| <TeamReviews periodId={selectedPeriod} /> | ||
| <TeamReviews | ||
| onBack={() => onPeriodSelected(null)} |
There was a problem hiding this comment.
This allows going back to the ReviewPeriods page from the TeamReviews page.
| teamMembers: PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| id: PropTypes.string, | ||
| firstName: PropTypes.string, |
There was a problem hiding this comment.
These props are not used.
| id: PropTypes.string, | ||
| firstName: PropTypes.string, | ||
| lastName: PropTypes.string | ||
| onBack: PropTypes.func |
There was a problem hiding this comment.
This is a new prop for returning to the ReviewPeriods page.
|
|
||
| return ( | ||
| <Root> | ||
| <Tooltip title="Back"> |
There was a problem hiding this comment.
New "Back" button for returning to the ReviewPeriods page.
You'll have to expand the diff for
TeamReviews.jsxto see my comments because that one is a large diff.