Feature 2212/enhanced checkin warranty #2359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
reviewed
May 10, 2024
| .map(id => pdls.find(pdl => pdl.id === id)) | ||
| .filter(Boolean); | ||
| setSelectedPdls(newPdls); | ||
| newPdls.length > 0 && setSelectedPdls(newPdls); |
Collaborator
There was a problem hiding this comment.
If newPdls becomes empty, does it to clear out the array of selected PDLs?
Contributor
Author
There was a problem hiding this comment.
For newPdls to become empty I believe we would have a data issue on our hands. This change is to allow us to short-circuit the logic for changing component state as the default state when no pdls are available is controlled in a useEffect queuing off processedQPs.current.
Collaborator
There was a problem hiding this comment.
I see what you're saying. This looks good. I actually didn't noticed that this was in code related to the query parameters. Makes sense now.
mvolkmann
approved these changes
May 10, 2024
vhscom
force-pushed
the
feature-2212/enhanced-checkin-warranty
branch
from
f7843d6 to
b29c3a1
Compare
mvolkmann
approved these changes
May 10, 2024
montesmoci
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page now properly selects all PDLs when the user navigates to the enhanced Check-Ins Report
Also updates card treatment to display Latest Activity using a new
--mutedutility compatible with AA conformance in contrast ratio measured using Firefox dev tools, and as close to4.5:1contrast as possible using whole numbers.