Skip to content

Feature 2289 review assignments #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvolkmann merged 14 commits into from
May 13, 2024
Merged

Feature 2289 review assignments #2365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f731981
progress on 2289
mvolkmann May 10, 2024
730fb63
Merge branch 'develop' into feature-2289-review-assignments
mvolkmann May 10, 2024
2202bdb
progress on 2289
mvolkmann May 10, 2024
5a006b5
progress on 2289
mvolkmann May 10, 2024
2cd12b2
progress on 2289
mvolkmann May 10, 2024
2b618e4
progress on 2289
mvolkmann May 10, 2024
886fb8c
progress on 2289
mvolkmann May 10, 2024
8d38e7d
progress on 2289
mvolkmann May 13, 2024
ce006e9
removed unused code from TeamReviews.tsx
mvolkmann May 13, 2024
e8abab5
progress on 2289
mvolkmann May 13, 2024
592020a
progress on TeamReviews
mvolkmann May 13, 2024
14400a4
progress on 2289
mvolkmann May 13, 2024
a2be6f2
progress on 2289
mvolkmann May 13, 2024
e81f063
progress on 2289
mvolkmann May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web-ui/src/components/member_selector/member_selector_dialog/MemberSelectorDialog.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ const MemberSelectorDialog = ({
);
}
}
}, [open]);
}, [open, selectedMembers]);
Copy link
Collaborator Author

@mvolkmann mvolkmann May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initializeChecked function called in this useEffect uses the value of selectedMembers.


// Change filter options when filter type is changed
useEffect(() => {
Expand Down
13 changes: 13 additions & 0 deletions web-ui/src/components/reviews/TeamReviews.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
.team-reviews {
Copy link
Collaborator Author

@mvolkmann mvolkmann May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This styles the rows of members and their reviewers.

& .chip-row {
display: flex;
align-items: center;
flex-wrap: wrap;
gap: 0.5rem;
margin-left: 2rem;
}

& .name-title {
min-width: 10rem;
}
}
Loading