Bugfix 2212/rewire report display #2375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
reviewed
May 14, 2024
| }; | ||
|
|
||
| const anyInProgress = members.some(isInProgress); | ||
| const anyInProgress = members.some( |
Collaborator
There was a problem hiding this comment.
I love use of the some and every Array methods!
mvolkmann
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered the previous page selector used in the Check-Ins was filtering out members without Check-Ins activity. Existing report logic is now replaced as expected per ACs in #2212 to report the expected PDL and team members.
Also updates our data load script to provide additional check-ins info to test reporting edge cases.
Finally, adds a keyboard listener to the Check-Ins report page for navigating quarters. This is especially helpful while making comparisons between quarters when the user's viewport has scrolled below the fold.