Feature 2290 confirm review period #2376
Conversation
| const handleLaunchDateChange = (val, period) => { | ||
| const newDate = val?.$d; | ||
| const isoDate = newDate.toISOString() ?? null; | ||
| const isoDate = newDate?.toISOString() ?? null; |
There was a problem hiding this comment.
If no launch date was specified, the ? here prevents an error from trying to call toISOString.
| } | ||
| }; | ||
|
|
||
| const validateReviewPeriod = period => { |
There was a problem hiding this comment.
This function implements review period validation that must hold in order to "REQUEST APPROVAL".
| ); | ||
| }; | ||
|
|
||
| const approvalButton = () => { |
There was a problem hiding this comment.
This function determines whether to render a button and what text should be on the button.
There was a problem hiding this comment.
Without knowing off hand how many ReviewStatus potentials there are could this have been a ternary?
There was a problem hiding this comment.
There are currently five ReviewStatus values, so I'm thinking there will be other button labels in the future.
|
|
||
| import { AddCircle, Archive, Delete, Unarchive } from '@mui/icons-material'; | ||
| import { | ||
| Alert, |
There was a problem hiding this comment.
Using for validation error messages.
| const handleCloseDateChange = (val, period) => { | ||
| const newDate = val?.$d; | ||
| const isoDate = newDate.toISOString() ?? null; | ||
| const isoDate = newDate?.toISOString() ?? null; |
There was a problem hiding this comment.
If no launch date was specified, the ? here prevents an error from trying to call toISOString.
| const handleSelfReviewDateChange = (val, period) => { | ||
| const newDate = val?.$d; | ||
| const isoDate = newDate.toISOString() ?? null; | ||
| const isoDate = newDate?.toISOString() ?? null; |
There was a problem hiding this comment.
If no launch date was specified, the ? here prevents an error from trying to call toISOString.
| {approvalButton()} | ||
| </div> | ||
| )} | ||
| {validationMessage && ( |
There was a problem hiding this comment.
If there is a validation error message, display it in an Alert.
jackkeller
left a comment
jackkeller
left a comment
There was a problem hiding this comment.
Left a comment, not a dealbreaker.
No description provided.