Feature 2364/feedback notification reports false success

server/src/main/java/com/objectcomputing/checkins/notifications/email/MailJetNotificationController.java

@@ -27,12 +27,18 @@ public MailJetNotificationController(CurrentUserServices currentUserServices,
     }
 
     @Post()
-    public Mono<? extends HttpResponse<?>> sendEmailReceivesStatus(String subject, String content, String... recipients) {
+    public Mono<HttpResponse<?>> sendEmailReceivesStatus(String subject, String content, String... recipients) {
         return Mono.fromCallable(currentUserServices::getCurrentUser)
                 .map(currentUser -> {
                     String fromName = currentUser.getFirstName() + " " + currentUser.getLastName();
                     return emailSender.sendEmailReceivesStatus(fromName, currentUser.getWorkEmail(), subject, content, recipients);
                 })
-                .map(success -> (HttpResponse<?>) HttpResponse.ok());
+                .map(success -> {
+                    if(success){
+                        return HttpResponse.ok();
+                    } else {
+                        return HttpResponse.serverError();
+                    }
+                });
     }
 }

server/src/main/resources/application.yml

@@ -34,7 +34,7 @@ micronaut:
   executors:
     io:
       type: fixed
-      n-threads: 80 # todo set value based on some multiple of available processors for better scalability. Micronaut's default is cores * 2, but that seems low.
+      n-threads: 40 # Keep in sync with max pool size on datasource
 
   security:
     enabled: true

web-ui/src/api/api.js

@@ -1,4 +1,4 @@
-import { UPDATE_TOAST } from '../context/actions';
+import {UPDATE_TOAST} from '../context/actions';
 import qs from 'qs';
 
 export const BASE_API_URL = import.meta.env.VITE_APP_API_URL
@@ -76,15 +76,21 @@ export const resolve = async payload => {
   };
 
   resolved.payload = await promise;
+
   if (!resolved.payload.ok) {
-    const statusText = resolved.payload.statusText;
-    resolved.error = await resolved.payload.json();
+    try {
+      resolved.error = await resolved.payload.json();
+    } catch (error) {
+      resolved.error = resolved.payload.statusText;
+      console.log(error);
+    }
+
     if (window.snackDispatch) {
       window.snackDispatch({
         type: UPDATE_TOAST,
         payload: {
           severity: 'error',
-          toast: resolved?.error?.message || statusText
+          toast: resolved?.error
         }
       });
     }