chore: update local cors config #2390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
approved these changes
May 15, 2024
vhscom
force-pushed
the
chore-0000/update-cors-config
branch
from
d7e867e to
7b3ab57
Compare
mvolkmann
approved these changes
May 16, 2024
vhscom
force-pushed
the
chore-0000/update-cors-config
branch
from
7b3ab57 to
703036e
Compare
montesmoci
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the micronaut upgrade in #2360 our HMR functionality began malfunctioning as pictured below. Looking at the latest CORS docs for Micronaut (4.4.x) https://docs.micronaut.io/latest/guide/index.html#cors I see the Regex property uses the name regex. When the name is configured like the documentation with the
Regexpostfix the regex works as expected and attempts to fetch resources from a browser on port5137will work as expected.