Feature 2347 pulse survey UI #2396
Conversation
| "vite": "^5.2.6", | ||
| "vite-tsconfig-paths": "^4.3.2", | ||
| "vitest": "^1.4.0", | ||
| "vitest": "^1.6.0", |
There was a problem hiding this comment.
Upgraded to the latest version.
| @@ -0,0 +1,74 @@ | |||
| import PropTypes from 'prop-types'; | |||
There was a problem hiding this comment.
This is a new component that displays a title, a row of sentiment icon buttons, and a text input for entering a comment.
| @@ -0,0 +1,31 @@ | |||
| .pulse { | |||
There was a problem hiding this comment.
CSS for the new Pulse component.
| @@ -0,0 +1,42 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Tests for new Pulse component.
| @@ -0,0 +1,308 @@ | |||
| // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html | |||
There was a problem hiding this comment.
Snapshot for new Pulse component.
| @@ -0,0 +1,14 @@ | |||
| .pulse-page { | |||
There was a problem hiding this comment.
CSS for new PulsePage component.
| @@ -1,11 +1,147 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Updated the placeholder PulsePage component with the intended content described in this story.
| <div className="pulse-page"> | ||
| {submittedToday ? ( | ||
| <Typography className="submitted-today" variant="h6"> | ||
| Thank you for submitting your pulse today! |
There was a problem hiding this comment.
Michael may be providing new copy text soon.
| @@ -0,0 +1,11 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Snapshot test for new PulsePage component.
| @@ -1,23 +1,23 @@ | |||
| import { defineConfig } from "vitest/config" | |||
There was a problem hiding this comment.
Prettier reformatted this.
| reporters: ["verbose"], | ||
| environment: 'jsdom', | ||
| setupFiles: './src/setupTests.js', | ||
| css: false, |
There was a problem hiding this comment.
Setting css to false is the only real change made in this file. Before this change we were getting the error "Could not parse CSS stylesheet" for any CSS files imported by a component that use nested CSS rules. It seems we don't really need to parse the CSS in order for all our existing tests to pass. I verified that.
vhscom
left a comment
vhscom
left a comment
There was a problem hiding this comment.
LGTM. I noticed we default users currently to dissatisfied. In a later iteration perhaps we don't default the user's settings, to help prevent them from submitting before they have explicitly selected internal/external pulse ratings.
|
From Michael ... |
No description provided.