Create permissions for managing review periods #2423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates the review period permissions as specified in #2223 and updates the controller to require them.
timyates
added
enhancement
mjperry91
approved these changes
May 21, 2024
ZacharyKlein
approved these changes
May 21, 2024
…ub.com/objectcomputing/check-ins into feature-2223/review-period-permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates the review period permissions as specified in #2223 and updates the controller to require them.
It specifies permissions for
CLOSEandLAUNCHthough at present, there is no REST API for these actions.However I included them, as they may be planned for future iterations.
Removed the check for admin user in the ReviewPeriodService as permissions are now checked at the controller layer.
Closes #2223