-
Notifications
You must be signed in to change notification settings - Fork 6
feature 2422 - last seen date #2424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-last-seen-date-users
…-last-seen-date-users
Appears to be a problem merged in from develop
...a/com/objectcomputing/checkins/services/memberprofile/currentuser/CurrentUserController.java
Outdated
Show resolved
Hide resolved
...a/com/objectcomputing/checkins/services/memberprofile/currentuser/CurrentUserController.java
Outdated
Show resolved
Hide resolved
server/src/main/resources/db/common/V103__alter_member_profile_table.sql
Outdated
Show resolved
Hide resolved
|
This PR is ready for review, but when I run the server tests I get the failures below. Can a server-side person look into these? @mjperry91 @ZacharyKlein @mkimberlin
MailJetSenderTest > initializationError FAILED CheckinsOpenIdAuthenticationMapperTest > initializationError FAILED GoogleServiceConfigurationTest > initializationError FAILED LocalLoginControllerTest > initializationError FAILED |
|
@mvolkmann I believe the issue is that you just need to rename the migration file to v105. I merged a v104 recently that you probably pulled in and its clashing |
Good catch Matt! I made that change and now I get this when starting the server: io.micronaut.context.exceptions.BeanInstantiationException: Bean definition [javax.sql.DataSource] could not be loaded: Validate failed: Migrations have failed validation Can you tell me how do to what it suggests on the last line? |
Its likely because the v104 from this pr was applied to your database, and now that you switched the names around, the v104 from develop is being applied instead, but they don't match so flyway doesn't know what to do. Simplest thing to do would be delete your db container, and redo podman compose up -d. I think that would fix this. Otherwise you can try messing around with flyway repair that it mentioned in the error, but I'm not 100% how to do that. |
|
The database migration issue is fixed and this PR is ready for review. |
mjperry91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
In relation to:
#2422