Feature 2433/enhance settings controller #2435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DTO to make logic on UI simpler.
…DTO to make logic on UI simpler.
…into feature-2433/enhance-settings-controller
Collaborator
Author
|
closes: #2433 |
jackkeller
approved these changes
May 23, 2024
Collaborator
jackkeller
left a comment
jackkeller
left a comment
There was a problem hiding this comment.
LGTM, though I know nothing of Java :D
timyates
approved these changes
May 24, 2024
| assertEquals(HttpStatus.UNAUTHORIZED,responseException.getStatus()); | ||
|
|
||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
For coverage, is it worth testing the UPDATE with an unknown (but valid) setting name, as in
Suggested change
| @Test | |
| void testPUTValidDTOButUnknownName() { | |
| final MemberProfile lucy = getMemberProfileRepository().save(mkMemberProfile("Lucy")); | |
| SettingsDTO updatedSetting = new SettingsDTO(); | |
| updatedSetting.setName(SettingOption.LOGO_URL.toString()); | |
| updatedSetting.setValue("Missing"); | |
| final HttpRequest<SettingsDTO> request = HttpRequest. | |
| PUT("/", updatedSetting).basicAuth(lucy.getWorkEmail(),ADMIN_ROLE); | |
| HttpClientResponseException responseException = assertThrows(HttpClientResponseException.class, | |
| () -> client.toBlocking().exchange(request, Map.class)); | |
| assertEquals(HttpStatus.NOT_FOUND, responseException.getStatus()); | |
| assertEquals("Setting with name %s not found.".formatted(SettingOption.LOGO_URL.toString()), responseException.getMessage()); | |
| } |
Collaborator
Author
There was a problem hiding this comment.
For coverage, is it worth testing the UPDATE with an unknown (but valid) setting name, as in
Good catch. Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.