fixes in PulsePage.jsx #2442
Merged
fixes in PulsePage.jsx #2442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
commented
May 24, 2024
| @@ -1,6 +1,6 @@ | |||
| import { format } from 'date-fns'; | |||
| import React, { useContext, useEffect, useState } from 'react'; | |||
| import {useHistory} from 'react-router-dom'; | |||
Collaborator
Author
There was a problem hiding this comment.
Just added spaces inside braces.
mvolkmann
commented
May 24, 2024
| if (res.error) throw new Error(res.error.message); | ||
|
|
||
| // Refresh browser to show that pulses where already submitted today. | ||
| history.push(location.pathname); |
Collaborator
Author
There was a problem hiding this comment.
The push method doesn't refresh the browser, but the go method does.
Contributor
There was a problem hiding this comment.
I didn't realize go was available in v5. Thanks!
mvolkmann
commented
May 24, 2024
| title="How you feeling about life outside of work?" | ||
| /> | ||
| <Button | ||
| disabled={!internalComment} |
Collaborator
Author
There was a problem hiding this comment.
Removed requirement to supply internalComment.
vhscom
approved these changes
May 24, 2024
…ing/check-ins into bugfix-pulse-report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.