1948 - Send email when PDL/Supervisor is added/updated to a member profile #2459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismckiernan
changed the title
chrismckiernan
force-pushed
the
feature-1948/send-pdl--notification-email
branch
7 times, most recently
from
a865933 to
b08448e
Compare
chrismckiernan
force-pushed
the
feature-1948/send-pdl--notification-email
branch
from
b08448e to
4ae04f0
Compare
mvolkmann
reviewed
May 31, 2024
mvolkmann
reviewed
May 31, 2024
mvolkmann
reviewed
May 31, 2024
mvolkmann
reviewed
May 31, 2024
mvolkmann
reviewed
May 31, 2024
mvolkmann
reviewed
May 31, 2024
mvolkmann
reviewed
May 31, 2024
mvolkmann
reviewed
May 31, 2024
chrismckiernan
force-pushed
the
feature-1948/send-pdl--notification-email
branch
2 times, most recently
from
7aa1ef8 to
b971d54
Compare
…t getting required input for sending the emails
chrismckiernan
force-pushed
the
feature-1948/send-pdl--notification-email
branch
from
b971d54 to
e4bbd76
Compare
mvolkmann
approved these changes
May 31, 2024
vhscom
reviewed
May 31, 2024
vhscom
suggested changes
May 31, 2024
Contributor
vhscom
left a comment
vhscom
left a comment
There was a problem hiding this comment.
In general I'd prefer to see us using const over let unless we plan to mutate the assignment later in the control flow logic. I think there were some examples of let in this code which were followed as a pattern, but it wasn't the ideal pattern.
…onst where possible
chrismckiernan
force-pushed
the
feature-1948/send-pdl--notification-email
branch
from
e8b42be to
2d62944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1948