Fix assertion with primitive and null #2463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst getting sonar working I spotted that we had warnings about comparing a primitive to null in the tests The lines looked like ``` assertNotNull(response.getContentLength()); ``` Which will always pass. Also saw some places where we had missed the assertion ``` response.equals(opportunitiesResponse); ``` Which I replaced with ``` assertEquals(Set.of(opportunitiesResponse), response.body()); ```
timyates
commented
Jun 3, 2024
Comment on lines
-188
to
+174
| assertNotNull(response.getContentLength()); | ||
| response.equals(opportunitiesResponse); | ||
| assertTrue(response.getContentLength() > 0, "response.getContentLength() > 0"); | ||
| assertEquals(Set.of(opportunitiesResponse), response.body()); |
Contributor
Author
There was a problem hiding this comment.
This is the thing that I changed here (there are 6 instances of the null check)
The rest is formatting... I wish git diff understood formatting a bit better... it never feels big enough to warrant a separate PR, but when put in here it makes it really hard to see what's going on 😿
mkimberlin
approved these changes
Jun 3, 2024
mjperry91
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst getting sonar working I spotted that we had warnings about comparing a primitive to null in the tests
The lines looked like
Which will always pass.
Also saw some places where we had missed the assertion
Which I replaced with