#2225 - updates permissions for reviews link #2467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jackkeller
commented
Jun 3, 2024
jackkeller
commented
- updates permissions for Feedback > Reviews ( removes isAdmin, adds hasReportPermissions)
chrismckiernan
approved these changes
Jun 3, 2024
mvolkmann
reviewed
Jun 3, 2024
mkimberlin
reviewed
Jun 4, 2024
web-ui/src/components/menu/Menu.jsx
Outdated
| ]; | ||
|
|
||
| const getFeedbackLinks = (isAdmin, isPDL, isSupervisor) => { | ||
| const getFeedbackLinks = (isAdmin, isPDL, isSupervisor, hasReportPermission) => { |
Member
There was a problem hiding this comment.
So, in looking at this again...this isn't actually the right permission set. I'll identify it and drop it to you shortly.
Collaborator
Author
There was a problem hiding this comment.
Okay, I'll work in the changes at that point.
Member
There was a problem hiding this comment.
These feedback links should be accessible as follows:
- FEEDBACK -> Any of
CAN_VIEW_FEEDBACK_ANSWER,CAN_VIEW_FEEDBACK_REQUEST,CAN_VIEW_REVIEW_PERIOD- View Feedback ->
CAN_VIEW_FEEDBACK_ANSWER - Received Requests ->
CAN_VIEW_FEEDBACK_REQUEST - Reviews ->
CAN_VIEW_REVIEW_PERIOD - Self-Reviews ->
CAN_VIEW_REVIEW_PERIOD
- View Feedback ->
Implementing this depends on PR #2476 being merged
Collaborator
Author
|
Aside from |
mvolkmann
approved these changes
Jun 5, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.