Reinstate RequestLogging for Local ENV #2469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Micronaut 4, the request attributes changed for routing. This means that our request logger broke as it was looking for routeInfo on the "micronaut.http.route" attribute which no-longer exists. This PR switches to use the new attribute to re-enable the logging, and introduces an order so we can capture security information. After discussion, this logger is only enabled when the LOCAL environment is enabled.
mjperry91
approved these changes
Jun 4, 2024
mkimberlin
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Micronaut 4, the request attributes changed for routing. This means that our request logger broke as it was looking for routeInfo on the "micronaut.http.route" attribute which no-longer exists.
This PR switches to use the new attribute to re-enable the logging, and introduces an order so we can capture security information.
After discussion, this logger is only enabled when the LOCAL environment is enabled.