check for Pulse report permission in UI #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
commented
Jun 5, 2024
| CAN_DELETE_REVIEW_PERIOD("Delete review period", "Review Period"), | ||
| CAN_ADMINISTER_SETTINGS("Add or edit settings", "Settings"), | ||
| CAN_VIEW_SETTINGS("View settings", "Settings"), | ||
| CAN_VIEW_ALL_PULSE_RESPONSES("View all pulse responses", "Pulse"); |
Collaborator
Author
There was a problem hiding this comment.
I moved this permission to the Reporting category since it is a kind of report and we don't have anything else in the Pulse category.
mvolkmann
commented
Jun 5, 2024
| @@ -1,8 +1,7 @@ | |||
| import { useMediaQuery } from '@mui/material'; | |||
| import React, { useState } from 'react'; | |||
Collaborator
Author
There was a problem hiding this comment.
useState is not used here.
mvolkmann
commented
Jun 5, 2024
| import React from 'react'; | ||
| import DesktopTable from './DesktopTable'; | ||
| import MobileTable from './MobileTable'; | ||
| import { allPermissions, roles } from './sample-data'; |
Collaborator
Author
There was a problem hiding this comment.
allPermissions and roles are not used here.
mvolkmann
commented
Jun 5, 2024
|
|
||
| // TODO: Uncomment this check after PR #2429 is merged. | ||
| //if (selectHasViewPulseReportPermission(state)) { | ||
| if (selectHasViewPulseReportPermission(state)) { |
Collaborator
Author
There was a problem hiding this comment.
This is working now.
mvolkmann
commented
Jun 5, 2024
| export const selectReviewPeriods = state => state.reviewPeriods; | ||
| export const selectPermissions = state => state.permissions; | ||
|
|
||
| const hasPermission = permissionName => createSelector( |
Collaborator
Author
There was a problem hiding this comment.
Prettier made lots of formatting changes in this file.
mvolkmann
commented
Jun 5, 2024
|
|
||
| useEffect(() => { | ||
| const getRolePermissions = async () => { | ||
| let res = await getRolePermissionsList(csrf); |
mvolkmann
commented
Jun 5, 2024
|
|
||
| // Mock the date if under test so the snapshot stays consistent | ||
| const today = process?.env?.VITEST_WORKER_ID ? new Date(2024, 5, 4) : new Date(); | ||
| const today = import.meta.env.VITEST_WORKER_ID |
Collaborator
Author
There was a problem hiding this comment.
This is a good change that Josh made in a separate PR.
vhscom
approved these changes
Jun 5, 2024
chrismckiernan
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.