-
Notifications
You must be signed in to change notification settings - Fork 6
Add API for managing volunteering #2490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We should really put required permissions on these APIs. I'm ok with doing a follow up issue for that so this can be merged, if you prefer @mvolkmann @timyates I'll approve and leave that to the two of you. |
|
@mvolkmann I've updated the PR description to list the available endpoints and how the permissions work... Please let me know if I've missed anything, or something could be changed to work better with the front end |
vhscom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Left one nice to have.
...rc/main/java/com/objectcomputing/checkins/services/volunteering/VolunteeringServiceImpl.java
Outdated
Show resolved
Hide resolved
| VolunteeringRelationship sarahLiftForLife = createVolunteeringRelationship(sarah.getId(), liftForLife.getId(), LocalDate.now().minusDays(2)); | ||
| VolunteeringRelationship timLiftForLife = createVolunteeringRelationship(tim.getId(), liftForLife.getId(), LocalDate.now()); | ||
| VolunteeringRelationship timFoodbankInactive = createVolunteeringRelationship(tim.getId(), foodbank.getId(), LocalDate.now().minusDays(3), null, false); | ||
| VolunteeringRelationship sarahFoodbank = createVolunteeringRelationship(sarah.getId(), foodbank.getId(), LocalDate.now().minusDays(10), LocalDate.now()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test fixtures make this nice and concise.
Volunteering Organization
Permissions
CAN_ADMINISTER_VOLUNTEERING_ORGANIZATIONSpermission can update organizationsData format
Note
activedefaults totrueif omittedEndpoints
Volunteering Relationship
Permissions
CAN_ADMINISTER_VOLUNTEERING_RELATIONSHIPSpermission can create or update relationships for other peopleData format
Note
endDateis optional andactivedefaults totrueif omittedEndpoints
Volunteering Event
Permissions
CAN_ADMINISTER_VOLUNTEERING_EVENTSpermission can create, update, or delete events for other people's relationshipsData format
Note
hoursmay not be negative, andnotesis optionalEndpoints